[XS] Change in coreboot[main]: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte - coreboot-gerrit

9 Jan 2025


      Attention is currently required from: Hung-Te Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85917?usp=email )
Change subject: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85917/comment/19f8d33c_15a1ae88?usp... :
PS1, Line 8:
...
Why is u8 the right one?
Because we use this API to manipulate one byte value written to the register. And it is quite obvious according to its naming.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85917?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02
Gerrit-Change-Number: 85917
Gerrit-PatchSet: 1
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 10 Jan 2025 04:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org