Attention is currently required from: Bao Zheng, Felix Held, Jason Nien, Martin Roth, Zheng Bao.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79172?usp=email )
Change subject: Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79172/comment/50135eb3_b986cd00 :
PS2, Line 22:
What testing has been done for this?
The original bug that landed these changes was: b/228830362: Nipperkin: Hang during S0i3 resume due to WLAN PSPP. The CLs that this is reverting did:
1. `TEST=Suspend stress test passes on Nipperkin`
2. `TEST=suspend_stress_test on AC and DC`
I think this should do the same before landing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79172?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id207076542edc8ea0cabc6e02e29856c2b6803c7
Gerrit-Change-Number: 79172
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 27 Nov 2023 17:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment