Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Vasiliy Khoruzhick.
yuchi.chen@intel.com has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/85283?usp=email )
Change subject: soc/intel/common/block: Add const qualifier for input of pirq ops ......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/itss.h:
https://review.coreboot.org/c/coreboot/+/85283/comment/58a31497_c8eb17c8?usp... : PS5, Line 51: uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev);
I add changes for snowridge, could you please check if this is working on it? […]
In my local environment, without coressponding change in SNR, compiler reports the following conflict, I think the Jenkins build bot should also report it
``` CC ramstage/soc/intel/snowridge/itss.o src/soc/intel/snowridge/itss.c:14:10: error: conflicting types for 'itss_soc_get_on_chip_dev_pir'; have 'uint32_t(struct device *)' {aka 'unsigned int(struct device *)'} 14 | uint32_t itss_soc_get_on_chip_dev_pir(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from src/soc/intel/snowridge/itss.c:7: src/soc/intel/common/block/include/intelblocks/itss.h:51:10: note: previous declaration of 'itss_soc_get_on_chip_dev_pir' with type 'uint32_t(const struct device *)' {aka 'unsigned int(const struct device *)'} 51 | uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ make: *** [Makefile:430: build/ramstage/soc/intel/snowridge/itss.o] Error 1 ```
@sheng.tan@9elements.com, could you please take a look at it?