Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47158/1
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index d97a2b5..9018bdd 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -14,6 +14,7 @@ register "slow_ppt_time_constant" = "5" #second register "stapm_time_constant" = "200" #second register "sustained_power_limit" = "12000" #mw + register "thermctl_limit" = "90" #degrees C
register "telemetry_vddcr_vdd_slope" = "65599" #mA register "telemetry_vddcr_vdd_offset" = "0"
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 2:
Hi reviewers, could you please help review this patch? thank you!
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 2:
Hi reviewers, could you please help review this patch? thank you!
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 2: Code-Review+1
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... PS2, Line 9: register "system_config" = "3" This still looks wrong to me. Should we be using a "2" here instead of a 3?
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... PS2, Line 9: register "system_config" = "3"
This still looks wrong to me. […]
Yes, That should set "2" for TDP 15w and "3" for 25w. and since it also set the sustained_power_limit to 12w so it will be limited. Checking with IRM, the difference between "2" and "3" is only the sustained_power_limit. but suggest setting the system_config to "2" to prevent potential risk.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Kevin Chiu, Eric Peers, chris wang, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47158
to look at the new patch set (#3).
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
Update system config=2 to TDP 15W design.
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47158/3
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Kevin Chiu, Eric Peers, chris wang, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47158
to look at the new patch set (#4).
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
Update system config=2 to meet TDP 15W design.
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47158/4
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 4: Code-Review+1
lgtm now. Thanks.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Kevin Chiu, Eric Peers, chris wang, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47158
to look at the new patch set (#5).
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
Update system config=2 to meet TDP 15W design.
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47158/5
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v... PS2, Line 9: register "system_config" = "3"
Yes, That should set "2" for TDP 15w and "3" for 25w. […]
Done
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/5/src/mainboard/google/zork/v... PS5, Line 17: #degrees C the #degrees C can be dropped, since that's in already in the register name now
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Kevin Chiu, Eric Peers, chris wang, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47158
to look at the new patch set (#6).
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
Update system config=2 to meet TDP 15W design.
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47158/6
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/5/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/5/src/mainboard/google/zork/v... PS5, Line 17: #degrees C
the #degrees C can be dropped, since that's in already in the register name now
Done
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
Patch Set 6: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting ......................................................................
mb/google/zork: update berknip CHTC thermal setting
Update APU CHTC thermal temperature protection point: Temperature limit(C'): 90
Update system config=2 to meet TDP 15W design.
BUG=b:162377903 BRANCH=zork TEST=1. emerge-zork coreboot 2. check CHTC temperature by AMD utility
Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47158 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 602b5c7..f563419 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -6,7 +6,7 @@ # For the below fields, 0 indicates use SOC default
# System config index - register "system_config" = "3" + register "system_config" = "2"
# Set STAPM confiuration. All of these fields must be set >0 to take affect register "slow_ppt_limit_mW" = "20000" @@ -14,6 +14,7 @@ register "slow_ppt_time_constant_s" = "5" register "stapm_time_constant_s" = "200" register "sustained_power_limit_mW" = "12000" + register "thermctl_limit_degreeC" = "90"
register "telemetry_vddcr_vdd_slope_mA" = "65599" register "telemetry_vddcr_vdd_offset" = "0"
-
Chris Wang (Code Review) -
Eric Peers (Code Review)
-
Felix Held (Code Review)
-
Kevin Chiu (Code Review)