Change in coreboot[master]: soc/intel/common: Move L1_substates_control to pcie_rp.h - coreboot-gerrit

11 Jan 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49295 )
Change subject: soc/intel/common: Move L1_substates_control to pcie_rp.h
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/49295/comment/59c58b57_28be1cf1 
PS2, Line 37: enum L1_substates_control {
...
Maybe a comment too like, `/* This enum is for passing into an FSP UPD, typically PcieRpL1Substates  […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54574b606985e82d00beb1a61cce3097580366a4
Gerrit-Change-Number: 49295
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 03:37:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment