New patch to review for coreboot: 5a1d7c6 EC H8: remove depndence on IS_X201

[Vladimir Serbinenko]

Vladimir Serbinenko ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4282

-gerrit

commit 5a1d7c6d472950591a85eaacda7d3dacba8f3cdc
Author: Vladimir Serbinenko 
Date:   Tue Nov 26 16:04:09 2013 +0100

EC H8: remove depndence on IS_X201

Instead define brightness up/down function and gfx device and use
    preprocessor magic to glue it together.

Change-Id: I03074ae07b33c1546d229efc3e80606ddbee6300
    Signed-off-by: Vladimir Serbinenko 
---
 src/ec/lenovo/h8/acpi/ec.asl      | 20 ++++----------------
 src/mainboard/lenovo/t60/dsdt.asl |  3 +++
 src/mainboard/lenovo/x60/dsdt.asl |  3 +++
 3 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index e3c6796..6bdc708 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -97,35 +97,23 @@ Device(EC)
    	Notify(^SLPB, 0x80)
    }

-#if IS_ENABLED (CONFIG_BOARD_LENOVO_X201)
    /* Brightness up GPE */
    Method(_Q14, 0, NotSerialized)
    {
-		_SB.PCI0.GFX0.LCD0.INCB()
+		BRIGHTNESS_UP()
    }

/* Brightness down GPE */
    Method(_Q15, 0, NotSerialized)
    {
-		_SB.PCI0.GFX0.LCD0.DECB()
+		BRIGHTNESS_DOWN()
    }

+#ifdef ACPI_VIDEO_DEVICE
    /* Next display GPE */
    Method(_Q16, 0, NotSerialized)
    {
-		Notify (_SB.PCI0.GFX0, 0x82)
-	}
-#else
-	/* Brightness up GPE */
-	Method(_Q14, 0, NotSerialized)
-	{
-		\DSPC.BRTU ()
-	}
-
-	/* Brightness down GPE */
-	Method(_Q15, 0, NotSerialized)
-	{
-		\DSPC.BRTD()
+		Notify (ACPI_VIDEO_DEVICE, 0x82)
    }
 #endif
    /* AC status change: present */
diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl
index f32a220..fb1e58d 100644
--- a/src/mainboard/lenovo/t60/dsdt.asl
+++ b/src/mainboard/lenovo/t60/dsdt.asl
@@ -19,6 +19,9 @@
  * MA 02110-1301 USA
  */

+#define BRIGHTNESS_UP \DSPC.BRTU
+#define BRIGHTNESS_DOWN \DSPC.BRTD
+
 DefinitionBlock(
    "dsdt.aml",
    "DSDT",
diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl
index f32a220..fb1e58d 100644
--- a/src/mainboard/lenovo/x60/dsdt.asl
+++ b/src/mainboard/lenovo/x60/dsdt.asl
@@ -19,6 +19,9 @@
  * MA 02110-1301 USA
  */

+#define BRIGHTNESS_UP \DSPC.BRTU
+#define BRIGHTNESS_DOWN \DSPC.BRTD
+
 DefinitionBlock(
    "dsdt.aml",
    "DSDT",