Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62553 )
Change subject: mb/google/brya/var/kinox: update overridetree
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/kinox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62553/comment/5d682368_c9486ff7
PS9, Line 135: ACPI_PLD_GROUP
Can you please look into the `custom_pld` and assocaited properties in other brya variants and use that convention as well? ex: https://review.coreboot.org/c/coreboot/+/62321/24/src/mainboard/google/brya/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc
Gerrit-Change-Number: 62553
Gerrit-PatchSet: 9
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Wed, 09 Mar 2022 20:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment