Change in coreboot[master]: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc

This change moves the addition of CBFS SAR file from
intel/wifi/Makefile.inc to wifi/generic/Makefile.inc to keep it in the
same sub-directory as the Kconfig definition.

BUG=b:169802515
BRANCH=zork

Change-Id: I7ee33232b6a07bbf929f3a79fabe89130fb6fa6f
Signed-off-by: Furquan Shaikh 
---
M src/drivers/intel/wifi/Makefile.inc
M src/drivers/wifi/generic/Makefile.inc
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/46039/1

diff --git a/src/drivers/intel/wifi/Makefile.inc b/src/drivers/intel/wifi/Makefile.inc
index 57f60af..9bfdd79 100644
--- a/src/drivers/intel/wifi/Makefile.inc
+++ b/src/drivers/intel/wifi/Makefile.inc
@@ -1,7 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0-only

ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c
-
-cbfs-files-$(CONFIG_WIFI_SAR_CBFS)  += wifi_sar_defaults.hex
-wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
-wifi_sar_defaults.hex-type := raw
diff --git a/src/drivers/wifi/generic/Makefile.inc b/src/drivers/wifi/generic/Makefile.inc
index 6240c71..407041a 100644
--- a/src/drivers/wifi/generic/Makefile.inc
+++ b/src/drivers/wifi/generic/Makefile.inc
@@ -1 +1,5 @@
 ramstage-$(CONFIG_DRIVERS_WIFI_GENERIC) += generic.c
+
+cbfs-files-$(CONFIG_WIFI_SAR_CBFS)  += wifi_sar_defaults.hex
+wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
+wifi_sar_defaults.hex-type := raw

[Rob Barnes (Code Review)]

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

Patch Set 1: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Duncan Laurie, Rob Barnes, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46039

to look at the new patch set (#3).

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc

This change moves the addition of CBFS SAR file from
intel/wifi/Makefile.inc to wifi/generic/Makefile.inc to keep it in the
same sub-directory as the Kconfig definition.

BUG=b:169802515
BRANCH=zork

Change-Id: I7ee33232b6a07bbf929f3a79fabe89130fb6fa6f
Signed-off-by: Furquan Shaikh 
---
M src/drivers/intel/wifi/Makefile.inc
M src/drivers/wifi/generic/Makefile.inc
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/46039/3

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

Patch Set 6: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

Patch Set 6: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46039 )

Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
......................................................................

wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc

This change moves the addition of CBFS SAR file from
intel/wifi/Makefile.inc to wifi/generic/Makefile.inc to keep it in the
same sub-directory as the Kconfig definition.

BUG=b:169802515
BRANCH=zork

Change-Id: I7ee33232b6a07bbf929f3a79fabe89130fb6fa6f
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46039
Tested-by: build bot (Jenkins) 
Reviewed-by: Michael Niewöhner 
Reviewed-by: Martin Roth 
Reviewed-by: Rob Barnes 
Reviewed-by: Karthik Ramasubramanian 
---
M src/drivers/intel/wifi/Makefile.inc
M src/drivers/wifi/generic/Makefile.inc
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/drivers/intel/wifi/Makefile.inc b/src/drivers/intel/wifi/Makefile.inc
index 57f60af..9bfdd79 100644
--- a/src/drivers/intel/wifi/Makefile.inc
+++ b/src/drivers/intel/wifi/Makefile.inc
@@ -1,7 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0-only

ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c
-
-cbfs-files-$(CONFIG_WIFI_SAR_CBFS)  += wifi_sar_defaults.hex
-wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
-wifi_sar_defaults.hex-type := raw
diff --git a/src/drivers/wifi/generic/Makefile.inc b/src/drivers/wifi/generic/Makefile.inc
index 6240c71..407041a 100644
--- a/src/drivers/wifi/generic/Makefile.inc
+++ b/src/drivers/wifi/generic/Makefile.inc
@@ -1 +1,5 @@
 ramstage-$(CONFIG_DRIVERS_WIFI_GENERIC) += generic.c
+
+cbfs-files-$(CONFIG_WIFI_SAR_CBFS)  += wifi_sar_defaults.hex
+wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
+wifi_sar_defaults.hex-type := raw