Stanislaw Kaminski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 12:
Hi,
I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats:
- can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors
- display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie
I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen.
I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost.
Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Aleksei Kharlamov
derlafff@ya.ru
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: clayton craft
Gerrit-CC: slact
Gerrit-Comment-Date: Tue, 13 Oct 2020 11:16:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment