Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78865?usp=email )
Change subject: Update vboot submodule to upstream main ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
With this patch we get problems when we build our mc_apl4 mainboard. […]
Hmmm... that would be a problem with your host environment, not the coreboot mainboard target you're building. Can you explain what operating system (e.g. Linux distribution and version) you're building on, what libc you're using and what version it is?
+Ching-Kang, any idea what could cause this? Do you know what libdl is and why Uwe needs to link it explicitly but we don't? Would anything break if we just added it? (I do see a `/usr/lib/libdl.a` in my CrOS chroot, but it seems to be an empty archive. I guess for some versions of glibc this is a separate library, but for others it is included in libc but the libdl file is still provided for compatibility? So should we just add `-ldl` to LDFLAGS unconditionally?)
-
Julius Werner (Code Review)