Attention is currently required from: Marvin Evers.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/poppy: Use chipset dt reference names ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Patchset:
PS4: I actually drafted comments but I forgot to send them. Sorry..
File src/mainboard/google/poppy/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/2d096435_23686235 : PS4, Line 254: The commit message doesn't suggest that lines are removed and no lines were removed from the other files. It doesn't make a difference here, since the configuration is identical to the chipset devicetree, but please add it again.
https://review.coreboot.org/c/coreboot/+/79439/comment/e8f8da50_811417d3 : PS4, Line 379: device pci 1f.1 on end # P2SB : Same here. Please add these lines again.
PS4: Please indent the on keyword with tabs, and also in the other files. See the previous patches.