Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct mic pin configs
Commit 0558d0c [mb/google/beltino/**/hda_verb.c: Correct pin configs] incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19, so set them back to the correct values, which match the original Chromium sources (where the identifer in the NID comments were flipepd, which was the source of the confusion originally_.
Test: build/boot panther and zako variants, verify mic attached to 3.5mm jack functional
Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 4 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42499/1
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42499
to look at the new patch set (#2).
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct mic pin configs
Commit 0558d0c [mb/google/beltino/**/hda_verb.c: Correct pin configs] incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19, so set them back to the correct values, which match the original Chromium sources (where the NID identifiers in the pin config comments were reversed, which was the source of the confusion originally.
Test: build/boot panther and zako variants, verify mic attached to 3.5mm jack functional
Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 4 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42499/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
NID 0x18 is MIC1 PORTB, NID 0x19 is MIC2 PORTF.
Verified that google/panther is actually using MIC2 through boardviews.
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... PS2, Line 30: MIC2 PORTF MIC1 PORTB
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... PS2, Line 33: MIC1 PORTB MIC2 PORTF
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
(2 comments)
NID 0x18 is MIC1 PORTB, NID 0x19 is MIC2 PORTF.
Verified that google/panther is actually using MIC2 through boardviews.
ALC283 mic pin descriptions:
- MIC 1: pins 22, 21 - MIC 2: pins 17, 18
On Panther, MIC 1 goes to testpoints and MIC 2 goes to the 3.5mm jack.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42499
to look at the new patch set (#3).
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct mic pin configs
Commit 0558d0c [mb/google/beltino/**/hda_verb.c: Correct pin configs] incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19, so set them back to the correct values, which match the original Chromium sources (where the NID identifiers in the pin config comments were reversed, which was the source of the confusion originally.
Test: build/boot panther and zako variants, verify mic attached to 3.5mm jack functional
Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 4 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42499/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... PS2, Line 30: MIC2 PORTF
MIC1 PORTB
Done
https://review.coreboot.org/c/coreboot/+/42499/2/src/mainboard/google/beltin... PS2, Line 33: MIC1 PORTB
MIC2 PORTF
Done
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct mic pin configs
Commit 0558d0c [mb/google/beltino/**/hda_verb.c: Correct pin configs] incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19, so set them back to the correct values, which match the original Chromium sources (where the NID identifiers in the pin config comments were reversed, which was the source of the confusion originally.
Test: build/boot panther and zako variants, verify mic attached to 3.5mm jack functional
Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42499 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 4 files changed, 20 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index 878314b..550ae82 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC2 PORTF */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index 878314b..550ae82 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC2 PORTF */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index 878314b..550ae82 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC2 PORTF */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index 878314b..550ae82 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC2 PORTF */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)