Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Zhuohao Lee, EricR Lai, Karthik Ramasubramanian.
Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52395 )
Change subject: drivers/i2c/cs42l42: Add driver for generating device in SSDT
......................................................................
Patch Set 9:
(2 comments)
File src/drivers/i2c/cs42l42/cs42l42.c:
https://review.coreboot.org/c/coreboot/+/52395/comment/07bb3e3f_5533d6cc
PS8, Line 74: if(config->btn_det_init_dbnce > 200) {
space required before the open parenthesis '('
Please fix.
https://review.coreboot.org/c/coreboot/+/52395/comment/760bbf7a_917808e3
PS8, Line 82: if(config->btn_det_event_dbnce > 100) {
space required before the open parenthesis '('
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c3145b20a1ba743d91eb64b93cb001db3854c5d
Gerrit-Change-Number: 52395
Gerrit-PatchSet: 9
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 23 Apr 2021 09:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment