Attention is currently required from: Hung-Te Lin, Xixi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75815?usp=email )
Change subject: soc/mediatek: Add prompt for the SCRAMBLE config
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/75815/comment/204833fa_5f730157 :
PS2, Line 35: default y
Keep `default n` here.
As discussed in b/285474337, DRAM scramble is only enabled via DRAM full-calibration flow. Please also submit a patch to revise DRAM Scramble enabling flow and test your patch by 'select MEDIATEK_DRAM_SCRAMBLE` in mediatek/mt8188/Kconfig (as a TEST-ONLY patch).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75815?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I703ac9aa3ccc4dd9d0fef9949c6b0d49449971a4
Gerrit-Change-Number: 75815
Gerrit-PatchSet: 2
Gerrit-Owner: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 04:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment