Change in coreboot[master]: mb/google/volteer/var/voxel: Add gpio-keys ACPI node for PENH - coreboot-gerrit

2 Feb 2021


      Attention is currently required from: Nick Vaccaro, Sheng-Liang Pan, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49967 )
Change subject: mb/google/volteer/var/voxel: Add gpio-keys ACPI node for PENH
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49967/comment/c8786070_b96409be 
PS2, Line 13: TEST=emerge-volteer coreboot chromeos-bootimage
Have you tested that this change:
1) Ensures the stylus popup shows up in the UI when the pen is ejected, and the stylus popup disappears in the UI when the pen is inserted?
2) The pen eject can wake the system from S0ix?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0959df5d0f069048777df81b0d4092ea90314eb
Gerrit-Change-Number: 49967
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@chromium.org
Gerrit-Comment-Date: Tue, 02 Feb 2021 18:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment