Attention is currently required from: Felix Singer, Michał Żygowski, Michal Zygowski, Martin Roth.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59816 )
Change subject: mb/clevo/l140cu: drop System76 EC
......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15:
Yes, right. It's mostly the same code, but System76 use their own vendor directory. We just kept the S76 EC driver because many of their interfaces are (were?) compatible with the vendor firmware and so it does the necessary steps to make it booting.
Huh, didn't know anything worked at all, but I never tested it tbh. The reason to keep it was simply due to a bug in the Linux kernel which made it panic without a EC ACPI device present.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06abbde238be6d25842472a6a82159413ab52ef5
Gerrit-Change-Number: 59816
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Michal Zygowski
miczyg94@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michal Zygowski
miczyg94@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 09:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment