Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74096 )
Change subject: mb/google/myst: Declare CrOS GPIOs
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74096/comment/92be1f48_d14f76df
PS3, Line 9: Declare CrOS GPIOs for Myst, add relevant defines
nit:fill 80 chars then warp line
Done
File src/mainboard/google/myst/chromeos.c:
https://review.coreboot.org/c/coreboot/+/74096/comment/29389910_fcb65284
PS3, Line 6: static const struct cros_gpio cros_gpios[] = {
add this in gpio. […]
This is specific to chromeOS and belongs here. The macro below `DECLARE_CROS_GPIOS` performs all of the registration and what's needed for these to be accessible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie876883d6ee2e3bc6324c038cefee12d99702dc9
Gerrit-Change-Number: 74096
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 16:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment