Change in coreboot[master]: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36366 )
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Ia006331894a0d76cbd3914e0517d9caaa5d9e8b1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/36366/1
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl b/src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl index 264e962..1fa4415 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl +++ b/src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl @@ -45,7 +45,7 @@
Name (_HID, "PNP0A03")
- Method (_ADR, 0, NotSerialized) //Fake bus should be 0 + Method (_HID, 0, NotSerialized) //Fake bus should be 0 { Return (DADD(GHCN(HCIN), 0x00000000)) }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36366
to look at the new patch set (#2).
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Ia006331894a0d76cbd3914e0517d9caaa5d9e8b1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt3.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt4.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt5.asl 5 files changed, 1 insertion(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/36366/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36366
to look at the new patch set (#3).
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Ia006331894a0d76cbd3914e0517d9caaa5d9e8b1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/serengeti_cheetah_fam10/ssdt2.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt3.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt4.asl M src/mainboard/amd/serengeti_cheetah_fam10/ssdt5.asl 4 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/36366/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36366 )
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
Patch Set 3: Code-Review-1
-1 , as I'm not sure and somehow confused ...
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/36366 )
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36366 )
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
Patch Set 3: Code-Review-1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36366 )
Change subject: mb/amd/serengeti_cheetah_fam10: Get rid of wrong _ADR object ......................................................................
Abandoned
see https://review.coreboot.org/c/coreboot/+/36961
-
HAOUAS Elyes (Code Review)