Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48830 )
Change subject: soc/intel: Drop unnecessary <soc/nvs.h> include ......................................................................
soc/intel: Drop unnecessary <soc/nvs.h> include
Change-Id: Ib78e746875e330e47540a6199343be62aa7e92a6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/baytrail/emmc.c M src/soc/intel/baytrail/sd.c M src/soc/intel/braswell/emmc.c M src/soc/intel/braswell/sd.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/48830/1
diff --git a/src/soc/intel/baytrail/emmc.c b/src/soc/intel/baytrail/emmc.c index e8253e0..8a2541c 100644 --- a/src/soc/intel/baytrail/emmc.c +++ b/src/soc/intel/baytrail/emmc.c @@ -7,7 +7,6 @@ #include <reg_script.h>
#include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/baytrail/sd.c b/src/soc/intel/baytrail/sd.c index 34a9031..b8473d8 100644 --- a/src/soc/intel/baytrail/sd.c +++ b/src/soc/intel/baytrail/sd.c @@ -7,7 +7,6 @@ #include <device/pci_ids.h>
#include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/braswell/emmc.c b/src/soc/intel/braswell/emmc.c index 954b5b4..4c8cbbf 100644 --- a/src/soc/intel/braswell/emmc.c +++ b/src/soc/intel/braswell/emmc.c @@ -7,7 +7,6 @@ #include <reg_script.h>
#include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/braswell/sd.c b/src/soc/intel/braswell/sd.c index 5d88016..9d18917 100644 --- a/src/soc/intel/braswell/sd.c +++ b/src/soc/intel/braswell/sd.c @@ -7,7 +7,6 @@ #include <device/pci_ids.h>
#include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h"
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48830
to look at the new patch set (#2).
Change subject: soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h> ......................................................................
soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h>
Change-Id: Ib78e746875e330e47540a6199343be62aa7e92a6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/baytrail/emmc.c M src/soc/intel/baytrail/sd.c M src/soc/intel/braswell/emmc.c M src/soc/intel/braswell/sd.c 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/48830/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48830 )
Change subject: soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h> ......................................................................
Patch Set 3: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48830 )
Change subject: soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h> ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48830 )
Change subject: soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h> ......................................................................
soc/intel: Replace <soc/nvs.h> with <soc/device_nvs.h>
Change-Id: Ib78e746875e330e47540a6199343be62aa7e92a6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48830 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/baytrail/emmc.c M src/soc/intel/baytrail/sd.c M src/soc/intel/braswell/emmc.c M src/soc/intel/braswell/sd.c 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/baytrail/emmc.c b/src/soc/intel/baytrail/emmc.c index e8253e0..e672b58 100644 --- a/src/soc/intel/baytrail/emmc.c +++ b/src/soc/intel/baytrail/emmc.c @@ -6,8 +6,8 @@ #include <device/pci_ids.h> #include <reg_script.h>
+#include <soc/device_nvs.h> #include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/baytrail/sd.c b/src/soc/intel/baytrail/sd.c index 34a9031..0a015c8 100644 --- a/src/soc/intel/baytrail/sd.c +++ b/src/soc/intel/baytrail/sd.c @@ -6,8 +6,8 @@ #include <device/pci.h> #include <device/pci_ids.h>
+#include <soc/device_nvs.h> #include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/braswell/emmc.c b/src/soc/intel/braswell/emmc.c index 954b5b4..d3c5aa8 100644 --- a/src/soc/intel/braswell/emmc.c +++ b/src/soc/intel/braswell/emmc.c @@ -6,8 +6,8 @@ #include <device/pci_ids.h> #include <reg_script.h>
+#include <soc/device_nvs.h> #include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h" diff --git a/src/soc/intel/braswell/sd.c b/src/soc/intel/braswell/sd.c index 5d88016..39a44db 100644 --- a/src/soc/intel/braswell/sd.c +++ b/src/soc/intel/braswell/sd.c @@ -6,8 +6,8 @@ #include <device/pci.h> #include <device/pci_ids.h>
+#include <soc/device_nvs.h> #include <soc/iosf.h> -#include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include "chip.h"
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)