Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Utkarsh Verma.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows ......................................................................
Patch Set 4:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74128/comment/280bd720_bb435755 PS4, Line 148: char string_buffer[15];
Yeah, this specific case would be fine I guess. […]
It's most likely that Coverity isn't aware that the memory being written to is actually free.
Sorry, can't see how changing the format specifiers and reducing the buffer size would fix anything or somehow make Coverity happy.
https://review.coreboot.org/c/coreboot/+/74128/comment/5583eac8_dcd455e7 PS4, Line 552: static unsigned short cnt = 0;
`buf` is only 8 bytes long, so `cnt` should not occupy more than 4 bytes. […]
No. https://web.archive.org/web/20230305063934/https://notabs.org/coding/smallIn...
-
Angel Pons (Code Review)