Attention is currently required from: Felix Singer, Filip Lewiński, Intel coreboot Reviewers, Krystian Hebel, Martin Roth, Michał Kopeć, Michał Żygowski, Paul Menzel.
Jérémy Compostella has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83730?usp=email )
Change subject: soc/intel/cannonlake: Let coreboot lock MSR_IA32_DEBUG_INTERFACE
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File src/soc/intel/cannonlake/lockdown.c:
https://review.coreboot.org/c/coreboot/+/83730/comment/8bc902b5_0ad4617e?usp... :
PS8, Line 3: #include <cpu/x86/msr.h>
: #include <cpu/intel/msr.h>
I know this is not a formal rule, but implicitly we generally try to keep the header file inclusion alphabetically ordered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83730?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ed4382bbe68f03e8eca151245c13928609f434f
Gerrit-Change-Number: 83730
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: coreboot org
coreboot.org@gmail.com
Gerrit-CC: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Feb 2025 16:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes