Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Angel Pons, Lean Sheng Tan, Werner Zeh, Andrey Petrov, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55586 )
Change subject: soc/intel/apollolake: Change PMC BAR read function term
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/apollolake/include/soc/pm.h:
https://review.coreboot.org/c/coreboot/+/55586/comment/fb5dd331_8a9e7fdc
PS2, Line 237: pmc_mmio_regs
There is already a function `soc_read_pmc_base()` that returns the base address for PMC memory mapped registers. It is documented here: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
For your EPOC change, you need to use `soc_read_pmc_base()` instead of `pmc_mmio_regs()`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6406b12b62a3e744d3be90c53f0870d693cec401
Gerrit-Change-Number: 55586
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 17 Jun 2021 19:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment