Attention is currently required from: Furquan Shaikh, Shreesh Chhabbi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
......................................................................
Patch Set 6:
(4 comments)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/79990e0a_cb705aa2
PS6, Line 65: //disable_mask |= LPM_S0i3_0 | LPM_S0i3_1 |
trailing whitespace
https://review.coreboot.org/c/coreboot/+/49766/comment/9f88e12c_75346417
PS6, Line 72: /* If external phy gating is not implemented,
trailing whitespace
https://review.coreboot.org/c/coreboot/+/49766/comment/2dee9185_89f7b51f
PS6, Line 78: if (is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_BT)) ||
trailing whitespace
https://review.coreboot.org/c/coreboot/+/49766/comment/ae0ba2e9_4cb460d0
PS6, Line 79: is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_WIFI)) ||
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9
Gerrit-Change-Number: 49766
Gerrit-PatchSet: 6
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 00:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment