Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
util/superiotool: Add EC registers for IT8728F
Add support for dumping registers, default values for EC on ITE IT8128F. Taken from datasheet 'IT8728F V0.4.2'
Test: 'superiotool -d -e' on board with IT8728F Super IO
Change-Id: I7074b740565edf458d6894c066b61c083a657cb8 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M util/superiotool/ite.c 1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/44417/1
diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 458250a..ff2d8a4 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -1244,6 +1244,31 @@ 0x00,0xff,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, 0x00,EOT}}, {EOT}}}, + {0x8728, "IT8728F", { + {NOLDN, NULL, + {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,0x0a,0x0b,0x0c,0x0d,0x0e,0x0f, + 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x18,0x19,0x1a,0x1b,0x1c,0x1d, + 0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x28,0x29,0x2a,0x2b, + 0x30,0x31,0x32,0x33,0x34,0x35,0x36,0x37,0x38,0x39,0x3a,0x3b,0x3c,0x3d,0x3e,0x3f, + 0x40,0x41,0x42,0x43,0x44,0x45, + 0x50,0x51,0x52,0x53,0x54,0x55,0x56,0x57,0x58,0x59,0x5b,0x5c,0x5d,0x5e,0x5f, + 0x60,0x61,0x62,0x63,0x64,0x65,0x66,0x68,0x69,0x6a,0x6b,0x6c,0x6d,0x6e, + 0x70,0x71,0x72,0x73,0x74,0x75,0x76, + 0x80,0x81,0x82,0x83,0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d,0x8e,0x8f, + 0x90,0x91,0x92,0x94,0x95,0x96,0x98,0x99,0x9c,0x9d,0x9e,0x9f, + EOT}, + {0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x80,0x58,0x0f,0x00,MISC,MISC,MISC, + MISC,MISC,MISC,0x07,0x40,0x00,0x00,0x00,NANA,NANA,NANA,MISC,MISC,MISC, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,MISC,MISC,MISC,MISC,MISC, + 0x00,0x00,0x7f,0x7f,0x7f,0x40,0x00,0x00,0x90,0x00,0x12,0x60,0x00,0x00,0x00, + 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f, + 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f, + NANA,NANA,NANA,NANA,MISC,MISC,MISC,MISC,0x00,0x00,0x00,0x00,0x00,0x00,0x00,NANA, + 0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0x00,MISC,0x00,MISC, + EOT}}, + {EOT}}}, {0x8783, "IT8783E/F", { {NOLDN, NULL, {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
Patch Set 1:
note: next patch set will reformat into usual 'block' layout; current layout is for ease of review / alignment of registers and default values
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
Patch Set 1:
seems current convention is to use 'NANA' for RO registers w/o a default value and 'MISC' for RW ones w/o a default, so that's what I've done here. If not correct please LMK
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44417
to look at the new patch set (#2).
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
util/superiotool: Add EC registers for IT8728F
Add support for dumping registers, default values for EC on ITE IT8128F. Taken from datasheet 'IT8728F V0.4.2'
Test: 'superiotool -d -e' on board with IT8728F Super IO
Change-Id: I7074b740565edf458d6894c066b61c083a657cb8 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M util/superiotool/ite.c 1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/44417/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
Patch Set 2:
patch set 2 is simply a reformatting of the registers/defaults array to match existing pattern
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44417 )
Change subject: util/superiotool: Add EC registers for IT8728F ......................................................................
util/superiotool: Add EC registers for IT8728F
Add support for dumping registers, default values for EC on ITE IT8128F. Taken from datasheet 'IT8728F V0.4.2'
Test: 'superiotool -d -e' on board with IT8728F Super IO
Change-Id: I7074b740565edf458d6894c066b61c083a657cb8 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44417 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/superiotool/ite.c 1 file changed, 29 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 458250a..f8c425d1 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -1244,6 +1244,35 @@ 0x00,0xff,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, 0x00,EOT}}, {EOT}}}, + {0x8728, "IT8728F", { + {NOLDN, NULL, + {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09, + 0x0a,0x0b,0x0c,0x0d,0x0e,0x0f,0x10,0x11,0x12,0x13, + 0x14,0x15,0x16,0x17,0x18,0x19,0x1a,0x1b,0x1c,0x1d, + 0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x28,0x29,0x2a, + 0x2b,0x30,0x31,0x32,0x33,0x34,0x35,0x36,0x37,0x38, + 0x39,0x3a,0x3b,0x3c,0x3d,0x3e,0x3f,0x40,0x41,0x42, + 0x43,0x44,0x45,0x50,0x51,0x52,0x53,0x54,0x55,0x56, + 0x57,0x58,0x59,0x5b,0x5c,0x5d,0x5e,0x5f,0x60,0x61, + 0x62,0x63,0x64,0x65,0x66,0x68,0x69,0x6a,0x6b,0x6c, + 0x6d,0x6e,0x70,0x71,0x72,0x73,0x74,0x75,0x76,0x80, + 0x81,0x82,0x83,0x84,0x85,0x86,0x87,0x88,0x89,0x8a, + 0x8b,0x8c,0x8d,0x8e,0x8f,0x90,0x91,0x92,0x94,0x95, + 0x96,0x98,0x99,0x9c,0x9d,0x9e,0x9f,EOT}, + {0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x80, + 0x58,0x0f,0x00,MISC,MISC,MISC,MISC,MISC,MISC,0x07, + 0x40,0x00,0x00,0x00,NANA,NANA,NANA,MISC,MISC,MISC, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + NANA,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,MISC,MISC,0x00,0x00,0x7f,0x7f,0x7f,0x40,0x00, + 0x00,0x90,0x00,0x12,0x60,0x00,0x00,0x00,0x7f,0x7f, + 0x7f,0x00,0x00,0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00, + 0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,NANA, + NANA,NANA,NANA,MISC,MISC,MISC,MISC,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,NANA,0xff,0x00,0x00,0xff,0x00, + 0x00,0x00,0x00,0x00,MISC,0x00,MISC,EOT}}, + {EOT}}}, {0x8783, "IT8783E/F", { {NOLDN, NULL, {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)