[S] Change in coreboot[main]: Don't build a separate romstage by default on most x86 targets
Attention is currently required from: Andrey Petrov, Arthur Heymans, Frans Hendriks, Paul Menzel, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email )
Change subject: Don't build a separate romstage by default on most x86 targets ......................................................................
Patch Set 51:
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/63419/comment/194dd7c7_070f428c : PS11, Line 1389: default n if ARCH_X86
Should this really be a test for NO_XIP_EARLY_STAGES instead? […]
No, I think my point was rather about what to base the heuristic upon for where it makes sense to enable this config by default. The main trade-off is between saving load time because things that are common between stages (e.g. printf code) don't need to be loaded twice, and saving load time on later stages due to compression. I was assuming you made your "default on x86 targets" decision here because XIP stages cannot be compressed anyway, so there the savings from merging stages should always win out? But NO_XIP_EARLY_STAGES boards (including AMD) _can_ compress their romstage, so that logic shouldn't count for them?
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/63419/comment/2e7f9f78_04c32920 : PS51, Line 93: select SEPARATE_ROMSTAGE
Why should this change here? […]
Okay, thinking about it some more I see that this is probably the better way.
-
Julius Werner (Code Review)