Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64009 )
Change subject: nb/amd/agesa/family14: Clean up fx_devs stuff ......................................................................
Patch Set 1:
(3 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/64009/comment/f092a0b3_e4c59214 PS1, Line 78: if (fx_devs == 0)
I'm not sure if fx_devs have been populated when this gets called. […]
It's redundant with the `if` inside get_fx_devs(). Anyway, doesn't matter if the cleanup continues.
https://review.coreboot.org/c/coreboot/+/64009/comment/71860ced_06a64f60 PS1, Line 86: if (fx_devs == 0)
I'm not sure if fx_devs have been populated when this gets called. […]
Same.
https://review.coreboot.org/c/coreboot/+/64009/comment/91a73434_8727581e PS1, Line 88: for (i = 0; i < fx_devs; i++) {
I'm not sure if fx_devs have been populated when this gets called. […]
After calling get_fx_devs() above, `fx_devs` is always `>= 1` (unless we are dead). Anyway...