Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
3 comments:
File src/northbridge/amd/agesa/family14/northbridge.c:
Patch Set #1, Line 78: if (fx_devs == 0)
I'm not sure if fx_devs have been populated when this gets called. […]
It's redundant with the `if` inside get_fx_devs(). Anyway, doesn't
matter if the cleanup continues.
Patch Set #1, Line 86: if (fx_devs == 0)
I'm not sure if fx_devs have been populated when this gets called. […]
Same.
Patch Set #1, Line 88: for (i = 0; i < fx_devs; i++) {
I'm not sure if fx_devs have been populated when this gets called. […]
After calling get_fx_devs() above, `fx_devs` is always `>= 1` (unless we are dead). Anyway...
To view, visit change 64009. To unsubscribe, or for help writing mail filters, visit settings.