Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29775 )
Change subject: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI ......................................................................
Patch Set 1:
(1 comment)
If the Kconfig option is used in ec/google/chromeec, it should also be defined there (and named accordingly).
https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c File src/ec/google/chromeec/smihandler.c:
https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c@... PS1, Line 103: A nicer way to code it in C would be to put something like this here:
if (IS_ENABLED(CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI)) return;
The compiler would take care of the dead code but it would still be compile tested (no matter the config state).