Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: soc/qualcomm/common: Add dram information to CBMEM table ......................................................................
Patch Set 42:
(4 comments)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/59195/comment/11e3e07f_74b1c806 PS41, Line 37: if (sizeof(struct mem_chip_info) != 0)
What is this supposed to test, this can never be false? The thing you were supposed to check is `(te […]
Taken care with below CL: https://review.coreboot.org/c/coreboot/+/63026
https://review.coreboot.org/c/coreboot/+/59195/comment/ed3b65ae_5d19cde2 PS41, Line 39: sizeof(struct mem_chip_info)
edit: sorry forgot to add that since this helper goes into a header file, it should be declared `sta […]
Taken care with below CL: https://review.coreboot.org/c/coreboot/+/63026
https://review.coreboot.org/c/coreboot/+/59195/comment/63e0139b_4861e190 PS41, Line 43: sizeof(struct mem_chip_info)
Same here.
Taken care with below CL: https://review.coreboot.org/c/coreboot/+/63026
https://review.coreboot.org/c/coreboot/+/59195/comment/4ac3e93b_e3f69c0a PS41, Line 174: mem_chip_addr, sizeof(mem_chip_addr)
This was supposed to be NULL and 0, and the comment above should clarify that the blob_address for t […]
Taken care with below CL: https://review.coreboot.org/c/coreboot/+/63026