Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32390
Change subject: linuxboot/Kconfig: Remove symbol name of a `choice` ......................................................................
linuxboot/Kconfig: Remove symbol name of a `choice`
Kconfig somehow adds spurious booleans for each alternative when the choice itself has a name. That's fixed simply by removing the name.
Change-Id: Ic35f0697f1f7bb92c12414c17a8790464b376012 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/32390/1
diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index ccf62b8..84af49c 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -123,7 +123,7 @@
Note: this can be a defconfig file or a complete .config file.
-choice LINUXBOOT_KERNEL_FORMAT +choice prompt "Kernel binary format" default LINUXBOOT_KERNEL_BZIMAGE if LINUXBOOT_X86 || LINUXBOOT_X86_64 default LINUXBOOT_KERNEL_UIMAGE if LINUXBOOT_ARM64
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32390 )
Change subject: linuxboot/Kconfig: Remove symbol name of a `choice` ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32390 )
Change subject: linuxboot/Kconfig: Remove symbol name of a `choice` ......................................................................
linuxboot/Kconfig: Remove symbol name of a `choice`
Kconfig somehow adds spurious booleans for each alternative when the choice itself has a name. That's fixed simply by removing the name.
Change-Id: Ic35f0697f1f7bb92c12414c17a8790464b376012 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/32390 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index ccf62b8..84af49c 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -123,7 +123,7 @@
Note: this can be a defconfig file or a complete .config file.
-choice LINUXBOOT_KERNEL_FORMAT +choice prompt "Kernel binary format" default LINUXBOOT_KERNEL_BZIMAGE if LINUXBOOT_X86 || LINUXBOOT_X86_64 default LINUXBOOT_KERNEL_UIMAGE if LINUXBOOT_ARM64
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32390 )
Change subject: linuxboot/Kconfig: Remove symbol name of a `choice` ......................................................................
Patch Set 2: Code-Review+1
-
Lijian Zhao (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)