Change in ...coreboot[master]: soc/intel/cpulib: Add debug message to mca_configure()

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31199


Change subject: soc/intel/cpulib: Add debug message to mca_configure()
......................................................................

soc/intel/cpulib: Add debug message to mca_configure()

Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Signed-off-by: Nico Huber <[e-mail]>
---
M src/soc/intel/common/block/cpu/cpulib.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31199/1

diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index d18b50c..ece79d6 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -323,6 +323,8 @@
 	int i;
 	int num_banks;
 
+	printk(BIOS_DEBUG, "Clearing out pending MCEs\n");
+
 	msr = rdmsr(IA32_MCG_CAP);
 	num_banks = msr.lo & 0xff;
 	msr.lo = msr.hi = 0;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31199
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-MessageType: newchange

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31199 )

Change subject: soc/intel/cpulib: Add debug message to mca_configure()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31199
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Fri, 01 Feb 2019 13:26:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31199 )

Change subject: soc/intel/cpulib: Add debug message to mca_configure()
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31199
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 01 Feb 2019 18:08:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31199 )

Change subject: soc/intel/cpulib: Add debug message to mca_configure()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31199
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 17:57:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31199 )

Change subject: soc/intel/cpulib: Add debug message to mca_configure()
......................................................................

soc/intel/cpulib: Add debug message to mca_configure()

Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Signed-off-by: Nico Huber <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/31199
Reviewed-by: Kyösti Mälkki <[e-mail]>
Reviewed-by: Paul Menzel <[e-mail]>
Reviewed-by: Angel Pons <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M src/soc/intel/common/block/cpu/cpulib.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved



diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index d18b50c..ece79d6 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -323,6 +323,8 @@
 	int i;
 	int num_banks;
 
+	printk(BIOS_DEBUG, "Clearing out pending MCEs\n");
+
 	msr = rdmsr(IA32_MCG_CAP);
 	num_banks = msr.lo & 0xff;
 	msr.lo = msr.hi = 0;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31199
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfe93e454cc0ce0d8e06e23beaddee2f11f5eedd
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: merged