Change in ...coreboot[master]: mb/google/poppy/variants/atlas: config GPP_D1 as no-connect
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31210 ) Change subject: mb/google/poppy/variants/atlas: config GPP_D1 as no-connect ...................................................................... mb/google/poppy/variants/atlas: config GPP_D1 as no-connect This reconfigures the GPP_D1 GPIO pin as a no-connect. It really doesn't go anywhere today or on previous revs of the board. BUG=b:110614620 BRANCH=none TEST=atlas still boots Change-Id: Iea53cf909f8f060c4e0f14e8b4ad579b838b7caa Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://review.coreboot.org/c/31210 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 5a76d83..372c66a 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -160,8 +160,8 @@ /* D0 : SPI1_CS# ==> NC */ PAD_CFG_NC(GPP_D0), - /* D1 : SPI1_CLK ==> TRACKPAD_RESET_1V8_ODL */ - PAD_CFG_GPO(GPP_D1, 0, DEEP), + /* D1 : SPI1_CLK ==> NC */ + PAD_CFG_NC(GPP_D1), /* D2 : SPI1_MISO ==> NC */ PAD_CFG_NC(GPP_D2), /* D3 : SPI1_MOSI ==> NC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/31210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea53cf909f8f060c4e0f14e8b4ad579b838b7caa Gerrit-Change-Number: 31210 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh@google.com> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> Gerrit-MessageType: merged
participants (1)
-
Patrick Georgi (Code Review)