Attention is currently required from: Mike Banon, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50789 )
Change subject: device/azalia: Switch to stopwatch ......................................................................
Patch Set 2:
(2 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/50789/comment/6a7a0adc_51f701e6 PS2, Line 178: udelay(1);
The CFL FSP doesn't have this delay.
Since this code is primarily used by AMD boards, it would be nice to have someone test that HDA still works there.
https://review.coreboot.org/c/coreboot/+/50789/comment/5a9f1dc3_b2df32c1 PS2, Line 174: stopwatch_init_usecs_expire(&sw, 50);
CFL FSP uses 10msec for iGPU here and 1msec for regular HDA codecs.
Do we ever hit the timeout? We could make the timeout delays configurable, too. Maybe also log an error if a function times out?
-
Angel Pons (Code Review)