Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73903 )
Change subject: Revert "device: Add Kconfig options for D3COLD_SUPPORT and NO_S0IX_SUPPORT" ......................................................................
Revert "device: Add Kconfig options for D3COLD_SUPPORT and NO_S0IX_SUPPORT"
This reverts commit 655f7362e13ca49e3e13a822c916c7dc52573d74.
Reason for revert: Apparently, the change was not properly reviewed. It not only contains conflicting name and description of the D3COLD Kconfig, but also creates a conflict between existing devicetree and Kconfig options for D3Cold/S3/S0ix.
Change-Id: I56ce8f59f8548fc58bc2b3b07c1314e2eed7061c Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/73903 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/device/Kconfig 1 file changed, 20 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index 30fcd38..ef73c40 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -998,19 +998,6 @@ help Provides xHCI utility functions.
-config NO_S0IX_SUPPORT - bool "Don't support S0IX suspend" - default n - help - Select if the board only supports S3 and/or S4 and not S0IX - -config D3COLD_SUPPORT - bool "Don't support D3Cold" - default n if NO_S0IX_SUPPORT - default y - help - Select if any devices don't support D3Cold state - source "src/device/dram/Kconfig"
endmenu