build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 85: else if (mux_data.dp) { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 89: tcss_req[4] = trailing whitespace
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 90: (mux_data.polarity ? (1 << 1) :0) | spaces required around that ':' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 91: (mux_data.cable ? (1 << 2) :0) | spaces required around that ':' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 96: if(mux_data.dp_mode <= MODE_DP_PIN_F) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 99: tcss_req[5] |= mux_data.hpd_lvl ? (1 << 6) :0; spaces required around that ':' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37870/11/src/soc/intel/tigerlake/ea... PS11, Line 113: if(ret) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)