Attention is currently required from: Ravi kumar, Taniya Das, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58580 )
Change subject: qualcomm/sc7280: gpio: Support eGPIO scheme
......................................................................
Patch Set 5:
(1 comment)
File src/soc/qualcomm/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/58580/comment/a33616d6_13f181af
PS2, Line 21: if ((read32(®s->cfg) >> GPIO_EGPIO_SHFT) & GPIO_EGPIO_BMSK)
I might be missing something here, but we want to set the 12th bit only in case the 11th bit (eGPIO_ […]
Would this work?
| (read32(®s->cfg) & GPIO_EGPIO_BMSK) << GPIO_EGPIO_SHFT)
Where:
GPIO_EGPIO_BMSK = BIT(11)
GPIO_EGPIO_SHFT = 1
Basically bitwise and to see if bit 11 is set and if it is, left shift by 1 to set bit 12. If bit 11 isn't set, the bitwise OR won't end up changing any bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2598a41ba3bb8a8a2acff8253b5bb78633f89f9
Gerrit-Change-Number: 58580
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 12 Nov 2021 00:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Taniya Das
quic_tdas@quicinc.com
Gerrit-MessageType: comment