Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 )
Change subject: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STORAGE_HOB2 HOB introduced in FSP 2.3 ......................................................................
Patch Set 9:
(3 comments)
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/59638/comment/0a825b71_05055b99 PS8, Line 25: #if CONFIG(PLATFORM_USES_FSP2_3)
suggestion: don't guard the definition of this, I will explain more below
Done
https://review.coreboot.org/c/coreboot/+/59638/comment/1765f593_53b88ac0 PS8, Line 318: #if CONFIG(PLATFORM_USES_FSP2_3) : : void *hob_ptr = NULL; : hob_ptr = fsp_find_extension_hob_by_guid(fsp_nv_storage_guid_2, size); : if (hob_ptr != NULL) { : size = (fsp_nvs_hob2_data_region_header *) hob_ptr->nvs_data_length; : return (fsp_nvs_hob2_data_region_header *) hob_ptr->nvs_data_ptr; : } : #endif : return fsp_find_extension_hob_by_guid(fsp_nv_storage_guid, size);
suggestion: we don't need the preprocessor, we can just do something like […]
Done
File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/59638/comment/8cb47c2e_e5e7b595 PS8, Line 30: #if CONFIG(PLATFORM_USES_FSP2_3) : struct fsp_nvs_hob2_data_region_header { : uint64_t nvs_data_ptr; : uint64_t nvs_data_length; : } __packed; : #endif :
no need to guard this
Done