Attention is currently required from: Ashish Kumar Mishra, Subrata Banik, Haribalaraman Ramasubramanian, Rizwan Qureshi, Krishna P Bhat D, Balaji Manigandan, Ronak Kanabar, Usha P.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69886 )
Change subject: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/intel/mtlrvp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/69886/comment/b10e8eff_d7d4e98f
PS7, Line 8: variant_configure_early_gpio_pads
wondering what would be the variant for RVP? is this meaningful even ?
Since this is now integral part of gpio.c, variant is not required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c0893e52036147c5f6bbfafc6d818e9d3460bed
Gerrit-Change-Number: 69886
Gerrit-PatchSet: 8
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 15:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment