Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
flora.fu@mediatek.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58969 )
Change subject: soc/mediatek/mt8195: Add APU device apc driver
......................................................................
Patch Set 9:
(3 comments)
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/2984a48c_ef51b72b
PS6, Line 196: ARRAY_SIZE(apusys_noc_dapc)
Then can we check the values are the same somewhere? […]
OK! Add add checking under array declaration.
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/c9b7d324_9c5d2fdd
PS8, Line 237:
Also print i? Same below.
Done
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/a4ce67ba_5a9b214d
PS9, Line 46: APUSYS_NOC_DAPC_AO_SLAVE_NUM
add checking for compile time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If92d3b02ac4966332315b85d68e0f48c6a9fce85
Gerrit-Change-Number: 58969
Gerrit-PatchSet: 9
Gerrit-Owner: flora.fu@mediatek.com
flora.fu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: flora.fu@mediatek.com
flora.fu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 07:35:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: flora.fu@mediatek.com
flora.fu@mediatek.com
Gerrit-MessageType: comment