Change in coreboot[master]: mb/prodrive/hermes: Drop Vref configuration for older boards
Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons. Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/62d36b66_d67bca7a PS1, Line 42: return AZALIA_PIN_DESC(
Should this use a separate association? Maybe 0x4 instead of 0xf? […]
with an association of 0x4, it would be 0x90100140. The third to last nibble is also used by the ALC888 for VREF output, Retaskable, Sensing support, jack detect override in that order. Here just setting jack detect override should be enough, though.
https://review.coreboot.org/c/coreboot/+/51919/comment/cf3d8ea8_5b1f1fca PS1, Line 69: 0x018707e1, /* port B VREF 50% of LDO-OUT */
will drop them here.
Ack
-
Justin van Son (Code Review)