Attention is currently required from: Eric Lai, Jason Nien, Kapil Porwal, Martin Roth, Nick Vaccaro, Subrata Banik.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80200?usp=email )
Change subject: mb/google/*: Replace use of gfx/generic addr field with display type ......................................................................
mb/google/*: Replace use of gfx/generic addr field with display type
Elminates the use of a magic number, and the resulting DID entry in the _DOD method is the same.
TEST=build/boot google/drallion, dump SSDT and verify DID entry unchanged.
Change-Id: Ic929cf7ec6849ba398653226bbe46d27b4e3fa81 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/brya/variants/anahera/overridetree.cb M src/mainboard/google/brya/variants/anahera4es/overridetree.cb M src/mainboard/google/brya/variants/anraggar/overridetree.cb M src/mainboard/google/brya/variants/banshee/overridetree.cb M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/crota/overridetree.cb M src/mainboard/google/brya/variants/dochi/overridetree.cb M src/mainboard/google/brya/variants/felwinter/overridetree.cb M src/mainboard/google/brya/variants/gimble/overridetree.cb M src/mainboard/google/brya/variants/gimble4es/overridetree.cb M src/mainboard/google/brya/variants/kano/overridetree.cb M src/mainboard/google/brya/variants/marasov/overridetree.cb M src/mainboard/google/brya/variants/mithrax/overridetree.cb M src/mainboard/google/brya/variants/omnigul/overridetree.cb M src/mainboard/google/brya/variants/osiris/overridetree.cb M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb M src/mainboard/google/brya/variants/skolas/overridetree.cb M src/mainboard/google/brya/variants/skolas4es/overridetree.cb M src/mainboard/google/brya/variants/taeko/overridetree.cb M src/mainboard/google/brya/variants/taeko4es/overridetree.cb M src/mainboard/google/brya/variants/taniks/overridetree.cb M src/mainboard/google/brya/variants/vell/overridetree.cb M src/mainboard/google/brya/variants/volmar/overridetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 28 files changed, 32 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/80200/1
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index 352a7d1..b26e424 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -93,7 +93,7 @@ # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -119,7 +119,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb index 6973854..93feca8 100644 --- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb @@ -75,7 +75,7 @@ # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -101,7 +101,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb index 456bb2f..75b98a1 100644 --- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb +++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb @@ -201,7 +201,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/banshee/overridetree.cb b/src/mainboard/google/brya/variants/banshee/overridetree.cb index 6f66bce..2602c97 100644 --- a/src/mainboard/google/brya/variants/banshee/overridetree.cb +++ b/src/mainboard/google/brya/variants/banshee/overridetree.cb @@ -100,7 +100,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 876e874..f15525b 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -124,7 +124,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb index 69f78c1..fa8a83e 100644 --- a/src/mainboard/google/brya/variants/crota/overridetree.cb +++ b/src/mainboard/google/brya/variants/crota/overridetree.cb @@ -113,7 +113,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/dochi/overridetree.cb b/src/mainboard/google/brya/variants/dochi/overridetree.cb index 461a7ad..facdfb2 100644 --- a/src/mainboard/google/brya/variants/dochi/overridetree.cb +++ b/src/mainboard/google/brya/variants/dochi/overridetree.cb @@ -93,7 +93,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb index 28e0974..16c44af 100644 --- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb +++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb @@ -99,7 +99,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0 diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index ed8027d..af41f84 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -80,7 +80,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb index 881c1a1..eada864 100644 --- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb @@ -45,7 +45,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index aeb8ef2..e044191 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -102,7 +102,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 5a266dd..35cd598 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -147,7 +147,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb index 55026ae..49dfea8 100644 --- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb +++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb @@ -97,7 +97,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0 diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb index 0ca36a7..a3a70ec 100644 --- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb +++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb @@ -132,7 +132,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb index 72981cf..9225c02 100644 --- a/src/mainboard/google/brya/variants/osiris/overridetree.cb +++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb @@ -76,7 +76,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index 7dde42f..c4b56eb 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -88,7 +88,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 1fe1682..1843670 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -108,7 +108,7 @@ # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -134,7 +134,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index b68dec2..99c29ee 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -89,7 +89,7 @@ # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -115,7 +115,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb index e3879bc..92f809f 100644 --- a/src/mainboard/google/brya/variants/skolas/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb @@ -123,7 +123,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb index 7826ea8..ef13b8e 100644 --- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb @@ -118,7 +118,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb index d6ffb7f..534b6c5 100644 --- a/src/mainboard/google/brya/variants/taeko/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb @@ -143,7 +143,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb index 753e7ba..fd20433 100644 --- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb @@ -124,7 +124,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb index a2d9512..9d89cd5 100644 --- a/src/mainboard/google/brya/variants/taniks/overridetree.cb +++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb @@ -120,7 +120,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index 459f782..01ded8e 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -99,7 +99,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/volmar/overridetree.cb b/src/mainboard/google/brya/variants/volmar/overridetree.cb index ef2da0a..069d221 100644 --- a/src/mainboard/google/brya/variants/volmar/overridetree.cb +++ b/src/mainboard/google/brya/variants/volmar/overridetree.cb @@ -94,7 +94,7 @@ # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index eecdc00..d6200d9 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -225,7 +225,7 @@ register "device[0].name" = ""LCD0"" # Address is set following the ACPI spec section A.3.2 # for an internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.detect_function" = ""\_SB.PCI0.LPCB.EC0.GPVD"" register "device[0].privacy.status_function" = ""\_SB.PCI0.LPCB.EC0.GPVX"" diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 0d5a383..cce354c 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -185,7 +185,7 @@ # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_18)" device generic 0.0 on diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index a4c29ca..81e7883 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -76,7 +76,7 @@ # Use ChromeOS privacy screen HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)" device generic 0 alias eps on end