Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin L Roth.
Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target ......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS5:
It's also not doing anything unreasonable. […]
We can't support everything. Our main project is not maintaining toolchains for everyones use case or even other projects. I don't want this to be a place where everyone can throw things in just because they have a use case for it. This has the potential to explode. It's 1329 lines of bash with your patch. This is not ideal.
It's great that it worked well for Google so far, but adding expectations on coreboot to support unrelated projects seems wrong to me. I think we removed the chromeec submodule not so long ago because no one maintained or updated it in coreboot. I've never saw anyone using the nds32le toolchain, but we still include it in a full build. Why? For what?
So, I want this to be specific to what coreboot needs. If it makes things easier for you now, another compromise for me would be to land this patch now, Google works out a solution in '25 and we remove it later.
What do you think?
-
Felix Singer (Code Review)