Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20398 )
Change subject: northbridge/intel: Add whitespace around '<<' ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.... File src/northbridge/intel/e7505/raminit.c:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/e7505/raminit.... PS5, Line 1849: | can you add spaces around | while here?
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/i945/raminit.c... PS5, Line 251: | spaces
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/ramin... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/pineview/ramin... PS5, Line 74: #define CHANNEL_IS_POPULATED(dimms, idx) ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0)) : #define CHANNEL_IS_CARDF(dimms, idx) ((dimms[idx << 1].card_type == 0xf) || (dimms[(idx << 1) + 1].card_type == 0xf)) : #define IF_CHANNEL_POPULATED(dimms, idx) if ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0)) break at 80
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/sandybridge/ra... PS5, Line 148: | spaces
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_dd... File src/northbridge/intel/x4x/raminit_ddr2.c:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/raminit_dd... PS5, Line 1620: (r) remove parentheses
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h File src/northbridge/intel/x4x/x4x.h:
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@184 PS5, Line 184: ((dimms[(ch << 1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch << 1) + 1].ranks + 2)))) break at 80
https://review.coreboot.org/#/c/20398/5/src/northbridge/intel/x4x/x4x.h@189 PS5, Line 189: (r) remove ()
-
Philippe Mathieu-Daudé (Code Review)