Philippe Mathieu-Daudé posted comments on this change.

View Change

Patch set 5:

(7 comments)

• File src/northbridge/intel/e7505/raminit.c:

  • Patch Set #5, Line 1849: |

    can you add spaces around | while here?

• File src/northbridge/intel/i945/raminit.c:

  • Patch Set #5, Line 251: |

    spaces

• File src/northbridge/intel/pineview/raminit.c:

  • Patch Set #5, Line 74:

    #define CHANNEL_IS_POPULATED(dimms, idx) ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))
    #define CHANNEL_IS_CARDF(dimms, idx) ((dimms[idx << 1].card_type == 0xf) || (dimms[(idx << 1) + 1].card_type == 0xf))
    #define IF_CHANNEL_POPULATED(dimms, idx) if ((dimms[idx << 1].card_type != 0) || (dimms[(idx << 1) + 1].card_type != 0))
    

    break at 80

• File src/northbridge/intel/sandybridge/raminit_common.h:

  • Patch Set #5, Line 148: |

    spaces

• File src/northbridge/intel/x4x/raminit_ddr2.c:

  • Patch Set #5, Line 1620: (r)

    remove parentheses

• File src/northbridge/intel/x4x/x4x.h:

  • Patch Set #5, Line 184: ((dimms[(ch << 1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch << 1) + 1].ranks + 2))))

    break at 80

  • Patch Set #5, Line 189: (r)

    remove ()

To view, visit change 20398. To unsubscribe, visit settings.