Change in coreboot[master]: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

Change in coreboot[master]:...

Felix Singer (Code Review)

7 Jan 2021 7 Jan '21

3:16 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

Braces are not necessary for single statement blocks. Remove them, so that linter doesn't complain. Also, put opening braces on the previous line.

Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c M src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c 2 files changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/49193/1

diff --git a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c index dd4c42b..7ca4a6e 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c @@ -7,8 +7,7 @@ #include <southbridge/amd/agesa/hudson/imc.h> #include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>

-const BIOS_CALLOUT_STRUCT BiosCallouts[] = -{ +const BIOS_CALLOUT_STRUCT BiosCallouts[] = { {AGESA_DO_RESET, agesa_Reset }, {AGESA_READ_SPD, agesa_ReadSpd }, {AGESA_READ_SPD_RECOVERY, agesa_NoopUnsupported }, @@ -41,8 +40,7 @@ {0xff, 0xffffffff} };

-static const CODEC_TBL_LIST CodecTableList[] = -{ +static const CODEC_TBL_LIST CodecTableList[] = { {0x10ec0272, (CODEC_ENTRY*)&Parmer_Alc272_VerbTbl[0]}, {(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL} }; diff --git a/src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c b/src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c index 0baf079..7a5cedd 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c @@ -78,9 +78,8 @@

sum = pirq->checksum - sum;

- if (sum != pirq->checksum) { + if (sum != pirq->checksum) pirq->checksum = sum; - }

printk(BIOS_INFO, "%s done.\n", __func__);

Attachments:

attachment.htm (text/html — 4.2 KB)

Show replies by date

Nico Huber (Code Review)

7 Jan 7 Jan

9:41 p.m.

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/49193/comment/952839a5_b9424e12 PS1, Line 7: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block That's completely personal preference, AFAICT. There are many people in the community against it. Is there really a linter for this or is it checkpatch?

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 20:41:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

11:26 p.m.

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/49193/comment/5bdb6db3_741b076e PS1, Line 10: Also, put opening braces on the previous : line. Summary doesn't account for this change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 22:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

8 Jan 8 Jan

7:43 a.m.

Attention is currently required from: Felix Singer. Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49193

to look at the new patch set (#2).

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

Braces are not necessary for single statement blocks. Remove them, so that linter doesn't complain.

Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/hp/pavilion_m6_1035dx/irq_tables.c 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/49193/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

7:44 a.m.

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/49193/comment/8e764cca_2c82754f PS1, Line 7: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

...

Is there really a linter for this or is it checkpatch?

It seems it's checkpatch.pl, but what's the difference between them? It appears in https://qa.coreboot.org/job/untested-coreboot-files/lastSuccessfulBuild/arti...

...

That's completely personal preference, AFAICT. There are many people in the community against it.

I understand that. Even it's only a warning, it's very irritating though. Like "should it be done like this or not"?

https://review.coreboot.org/c/coreboot/+/49193/comment/ee96e3c0_be9ab7b3 PS1, Line 10: Also, put opening braces on the previous : line.

...

Summary doesn't account for this change.

Moved into CB:49234

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 08 Jan 2021 06:44:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

7:16 p.m.

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/49193/comment/9a987229_48ae7c23 PS1, Line 7: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

...

...
Is there really a linter for this or is it checkpatch? […]

I don't remember if we came to any conclusion in [1]. Even if not, if there are enough arguments to not warn about too many braces, I'd ack a patch that removes that from checkpatch.

[1] [coreboot] More coding style change proposals

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 08 Jan 2021 18:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Felix Singer (Code Review)

9 Jan 9 Jan

4:10 p.m.

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49193

to look at the new patch set (#5).

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

Braces are not necessary for single statement blocks. Remove them, so that linter doesn't complain.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/49193/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

5:22 p.m.

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49193

to look at the new patch set (#6).

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

Braces are not necessary for single statement blocks. Remove them, so that linter doesn't complain.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/49193/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

5:23 p.m.

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49193

to look at the new patch set (#7).

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

mb/hp/pavilion_m6_1035dx: Remove braces from single statement block

Braces are not necessary for single statement blocks. Remove them, so that linter doesn't complain.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/49193/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/49193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e Gerrit-Change-Number: 49193 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

22 Apr 22 Apr

8:19 a.m.

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49193 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block ......................................................................

Abandoned

1469

days inactive

1574

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Felix Singer (Code Review)
Nico Huber (Code Review)