Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31653
Change subject: doc/util: Improve cbmem utility description ......................................................................
doc/util: Improve cbmem utility description
Change-Id: Ieddcf100d8db25f3ae9ac182cd374918e38d4f4c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M Documentation/util.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/31653/1
diff --git a/Documentation/util.md b/Documentation/util.md index f8fabc1..8f252c4 100644 --- a/Documentation/util.md +++ b/Documentation/util.md @@ -26,7 +26,7 @@ * _fmaptool_ - Converts plaintext fmd files into fmap blobs `C` * _rmodtool_ - Creates rmodules `C` * _ifwitool_ - For manipulating IFWI `C` -* __cbmem__ - Cbmem console log reader `C` +* __cbmem__ - CBMEM parser to read e.g. timestamps and console log `C` * __checklist__ - Board implementation checklist generator `Make` * __chromeos__ - These scripts can be used to extract System Agent reference code and other blobs (e.g. mrc.bin, refcode, VGA option roms)
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31653 )
Change subject: doc/util: Improve cbmem utility description ......................................................................
Patch Set 1:
As far as I remember this file is generated by a script in util/ from files residing in util/.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31653
to look at the new patch set (#2).
Change subject: util/cbmem: Improve utility description ......................................................................
util/cbmem: Improve utility description
Change-Id: Ieddcf100d8db25f3ae9ac182cd374918e38d4f4c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M util/cbmem/description.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/31653/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31653 )
Change subject: util/cbmem: Improve utility description ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31653 )
Change subject: util/cbmem: Improve utility description ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31653 )
Change subject: util/cbmem: Improve utility description ......................................................................
util/cbmem: Improve utility description
Change-Id: Ieddcf100d8db25f3ae9ac182cd374918e38d4f4c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/31653 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/cbmem/description.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/cbmem/description.md b/util/cbmem/description.md index 38977ec..36a6efa 100644 --- a/util/cbmem/description.md +++ b/util/cbmem/description.md @@ -1 +1 @@ -Cbmem console log reader `C` +CBMEM parser to read e.g. timestamps and console log `C`
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)