Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Why
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/56171/comment/0a1394a6_0cb2b092
PS4, Line 108: case PCI_DEVICE_ID_INTEL_Q570:
: case PCI_DEVICE_ID_INTEL_Z590:
: case PCI_DEVICE_ID_INTEL_H570:
: case PCI_DEVICE_ID_INTEL_B560:
: case PCI_DEVICE_ID_INTEL_H510:
: case PCI_DEVICE_ID_INTEL_WM590:
: case PCI_DEVICE_ID_INTEL_QM580:
: case PCI_DEVICE_ID_INTEL_HM570:
: case PCI_DEVICE_ID_INTEL_C252:
: case PCI_DEVICE_ID_INTEL_C256:
: case PCI_DEVICE_ID_INTEL_W580:
TGL-H should be handled the same way as TGL-LP
I agree (found via testing). On HM570, dumping GPIOs via MMIO method works and returned data seems generally sane.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08
Gerrit-Change-Number: 56171
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 19:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment