Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84930?usp=email )
Change subject: soc/mediatek/mt8196: Add SPI driver support ......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8196/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/84930/comment/77378dd5_457530c4?usp... : PS3, Line 8: #ifndef __SOC_MEDIATEK_MT8196_SPI_H__ Why change it? The code in mediatek/ is already inconsistent.
https://review.coreboot.org/c/coreboot/+/84930/comment/3db69873_0868ec4e?usp... : PS3, Line 15: x `(x)`
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/84930/comment/9cf45a66_cf894d7f?usp... : PS3, Line 123: SPI_BUS_NUMBER `ARRAY_SIZE(pad_funcs[0])`
I fixed mt8188 in CB:84950.