Attention is currently required from: Lance Zhao, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49317 )
Change subject: drivers/uart: Add ACPI SPCR table generation.
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49317/comment/3d892e39_7163b31f
PS3, Line 7: drivers/uart: Add ACPI SPCR table generation.
Nit: Can you please remove the period/dot at the end of the commit message summary?
https://review.coreboot.org/c/coreboot/+/49317/comment/bf939000_e89db51f
PS3, Line 21: TEST=Build
Does Linux log, that it detected this support?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e7c17adcf5b2a8206a8308e057855819ec413a
Gerrit-Change-Number: 49317
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 10:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment