build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48800 )
Change subject: soc/intel/apl: move UART pad config to boards ......................................................................
Patch Set 14:
(4 comments)
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48800/comment/749b823b_bac9ab9b PS14, Line 297: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART2_RXD */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48800/comment/681213a0_b51ce409 PS14, Line 298: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART2_TXD */ line over 96 characters
File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48800/comment/a5ddba8b_56f3778e PS14, Line 240: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_UART2_RXD */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48800/comment/4b4f1338_8c23e24b PS14, Line 241: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD),/* LPSS_UART2_TXD */ line over 96 characters